update api code owners to the right set of people-开源项目...

来自 : CSDN技术社区 发布时间：2021-03-25

私信 访问主页

weixin_39977776 2020-12-02 13:24 首页 开源项目 update api code owners to the right set of people

该提问来源于开源项目 istio/api

点赞 写回答 收藏 复制链接分享 删除 再等等 结题 再想想 12条回答

私信 访问主页

weixin_39800331 3月前

This whole CODEOWNERS change is not proving its utility. Why can t we have separate reviewers and approvers now?

点赞 评论 复制链接分享

私信 访问主页

weixin_39779467 3月前

Or even better: with a majority of TOC required for approval :-)

That would really make the APIs stable !

On Thu, Aug 8, 2019 at 6:20 PM Costin Manolache wrote:

To be clear: I don t mind if the list includes TOC members and nobodyelse, with 2 or 3 1 required for approval.

There are far too many API changes without sufficient TOC review andhaving a high bar for approval in API would be highly valuable.

On Thu, Aug 8, 2019 at 6:15 PM Shriram Rajagopalan notifications.com wrote:

Here is the kitchen sink from a few weeks ago

Please add your github ID alphabetically.

reviewers: - andraxylia - costinm - diemtvu - frankbu - geeknoid - GregHanson - hklai - kyessenov - mandarjog - ozevren - qiwzhang - rshriram - utka - wattliapprovers: - andraxylia - costinm - diemtvu - frankbu - geeknoid - GregHanson - hklai - kyessenov - mandarjog - ozevren - qiwzhang - rshriram - utka - wattli

hmm. I guess this matches the current codeowners..

You are receiving this because you were mentioned.Reply to this email directly, view it on GitHubhttps://github.com/istio/api/pull/1027?email_source notifications email_token AAAUR2XQMSCYH5U362STQCDQDTAJ3A5CNFSM4IKNHAL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35J7WQ#issuecomment-519741402,or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAAUR2VAVRZG7ROFONFVQA3QDTAJ3ANCNFSM4IKNHALQ.

评论 复制链接分享

私信 访问主页

weixin_39779467 3月前

To be clear: I don t mind if the list includes TOC members and nobody else,with 2 or 3 1 required for approval.

There are far too many API changes without sufficient TOC review and havinga high bar for approval in API would be highly valuable.

On Thu, Aug 8, 2019 at 6:15 PM Shriram Rajagopalan wrote:

Here is the kitchen sink from a few weeks ago

Please add your github ID alphabetically.

reviewers: - andraxylia - costinm - diemtvu - frankbu - geeknoid - GregHanson - hklai - kyessenov - mandarjog - ozevren - qiwzhang - rshriram - utka - wattliapprovers: - andraxylia - costinm - diemtvu - frankbu - geeknoid - GregHanson - hklai - kyessenov - mandarjog - ozevren - qiwzhang - rshriram - utka - wattli

hmm. I guess this matches the current codeowners..

You are receiving this because you were mentioned.Reply to this email directly, view it on GitHubhttps://github.com/istio/api/pull/1027?email_source notifications email_token AAAUR2XQMSCYH5U362STQCDQDTAJ3A5CNFSM4IKNHAL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35J7WQ#issuecomment-519741402,or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAAUR2VAVRZG7ROFONFVQA3QDTAJ3ANCNFSM4IKNHALQ 评论 复制链接分享

私信 访问主页

weixin_39903176 3月前

Maybe should also add owners to subdirectory, like networking, mixer, security, etc.

点赞 评论 复制链接分享

私信 访问主页

weixin_39977776 3月前

Here is the kitchen sink from a few weeks ago

# Please add your github ID alphabetically.reviewers: - andraxylia - costinm - diemtvu - frankbu - geeknoid - GregHanson - hklai - kyessenov - mandarjog - ozevren - qiwzhang - rshriram - utka - wattliapprovers: - andraxylia - costinm - diemtvu - frankbu - geeknoid - GregHanson - hklai - kyessenov - mandarjog - ozevren - qiwzhang - rshriram - utka - wattli

hmm. I guess this matches the current codeowners..

点赞 评论 复制链接分享

私信 访问主页

weixin_39977776 3月前

This was the list IIRC before the code owners. I for sure remember louisryan and sven being part of the owners for approving API prs. So I am simply trying to restore the old list. let me check with the old owners to make sure I got the names right.

点赞 评论 复制链接分享

私信 访问主页

weixin_39642998 3月前

I ve added an item to discuss this in the next TOC meeting on 8/9.

点赞 评论 复制链接分享

私信 访问主页

weixin_39779467 3月前

I can understand having only ToC members - since they need to approve the API changes, but it doesn t seem to be the case ( unless toc membership changed )

点赞 评论 复制链接分享

私信 访问主页

weixin_39779467 3月前

Seems a bit arbitrary - is this based on a ToC decision ? Or what was the criteria ?

点赞 评论 复制链接分享

私信 访问主页

weixin_39668470 3月前

1, what makes someone the right set of people ?

点赞 评论 复制链接分享

私信 访问主页

weixin_39800331 3月前

What makes an owner of the API? I d like to get a chance to review mixer-related APIs, for example.

点赞 评论 复制链接分享

私信 访问主页

weixin_39642998 3月前

I think the people who are being removed should get a chance to review this PR.

点赞 评论 复制链接分享 提交 再想想 采纳 为你推荐 使用unmarshal从响应中获取特定的JSON字段 json 2个回答更好的初始化 initialization 2个回答如何在Symfony4结构的参数文件中检索环境变量？ symfonyphp 2个回答CakePHP在订购后选择框值不对 php 2个回答基于模块化CMS的动态菜单模块的最佳实践 laravelphp 2个回答在Symfony中使用HWIOAuth进行Twitter身份验证 symfonyapiphp 1个回答仅显示随时间变化的行 mysqlphp 1个回答PHP会话混乱 classphpsession 4个回答为什么我的网站在我的代码编辑器预览中看起来很好但是它在实时网站上搞砸了？ [重复] csshtmlphp 2个回答Eloquent在急切加载模型关系时自动选择不需要的列 laravelphp 1个回答使用HWIOAuthBundle登录Facebook后，区域设置回退到默认值 symfonyphp 1个回答如何从wordpress中的自定义网关中的process_payment函数进行重定向？ wordpresspostphp 2个回答由于计数器PHP，结果显示两次 php 2个回答独立的Wamp服务器ssl auth设置 apachewindowsmysqlphp 1个回答无法选择3个用户ID相同的表。 没有错误出现 databasephp 1个回答我可以使用Eloquent通过父母的财产订购一系列儿童吗？ php 2个回答更改递归数组的内部值 scopearraysphp 2个回答如何使用hwioauthBundle获取oauth2之后的Google帐户电子邮件地址 google-apisymfonyphp 1个回答curl_exec和utf-8？ curlwidgetphp 2个回答谷歌驱动器api-File已上传但尚未列出 web-servicesgoogle-apiphp 1个回答 点击登录 提问题 欢迎建议意见 . 如何写高质量提问和回答？ 采纳榜7天 被采纳次数 ProfSnail 21 coagenth 16 幻灰龙 164 qq_34124780 145 Jack_Yang(数据分析及可视化) 126 规则边缘 117 GoCityPass新加坡曼谷通票 118 天际的海浪 99 cpp_learner 910 我不喜欢这个世界 9 加急问题 100 unity 设置Animation的culling type 导致游戏崩溃 75 数据库只有myd文件没有frm,myi文件，怎么打开呢 55 微服务框架，springboot启动异常 51 利用Adams联合matlab仿真求运动学反解问题 50 labview使用datasocket与c/c#程序的通信 50 已知地图GPS坐标点A和坐标点B，获取A点往B点直线走一定距离的坐标点经纬度？ 50 在不import任何东西并且限制交换次数的情况下做HeapSort和MergeSort？